fix kotlin verb registry #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
|
Nice spotting. Pretty sure that was my bad, sorry! |
alecthomas
approved these changes
Nov 7, 2023
| .forEach { | ||
| val kClass = it.loadClass().kotlin | ||
| if (kClass.hasAnnotation<Ignore>()) { | ||
| return@forEach |
There was a problem hiding this comment.
What's this magical syntax?!?
There was a problem hiding this comment.
usually it's not necessary but in the odd case comes in handy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual bug was in this line. This return statement bailed from the entire
registerAll()function, rather than theforEachiteration as intended. The fix is directing the return withreturn@forEach— the rest of this PR is small cosmetic changes for readability.This only affected modules compiled when other modules were active in the cluster because those contained generated stubs whose modules were annotated with
Ignore, causing this return to execute.fixes #559